Thread (18 messages) 18 messages, 5 authors, 2022-09-10

Re: [PATCH v2 1/3] dt-bindings: mediatek: Add gamma compatible for mt8195

From: zheng-yan.chen <hidden>
Date: 2022-08-31 03:08:59
Also in: dri-devel, linux-mediatek

On Tue, 2022-08-30 at 12:10 +0300, Krzysztof Kozlowski wrote:
On 30/08/2022 09:39, zheng-yan.chen wrote:
quoted
mt8195 uses 10bit-to-12bit gamma-LUT, which is not compatible with
current 9bit-to-10bit gamma-LUT.

This patch thus add constant compatible for mt8195, which means
that
mt8195 should only use specified mt8195 gamma driver data.

Also, delete related compatible from enum, to ensure that
mt8195 will not accidentally get others' gamma driver data and thus
cause fatal error.

Fixes: a79257bae9bf ("dt-bindings: display: mediatek: add mt8195
SoC binding for vdosys0")
Signed-off-by: zheng-yan.chen <redacted>
---
 .../devicetree/bindings/display/mediatek/mediatek,gamma.yaml   | 3
++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git
a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma
.yaml
b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma
.yaml
index a89ea0ea7542..fbd7b9664a78 100644
---
a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma
.yaml
+++
b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma
.yaml
@@ -25,11 +25,12 @@ properties:
           - const: mediatek,mt8173-disp-gamma
       - items:
           - const: mediatek,mt8183-disp-gamma
+      - items:
+          - const: mediatek,mt8195-disp-gamma
This is one item, so not a list. With all such cases this should be
dedicated enum.

Best regards,
Krzysztof
Hello Krzysztof, 
Thanks for the review,

I will fix it at the next version.

Best Regards,
Zheng-Yan Chen.


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help