Thread (8 messages) 8 messages, 7 authors, 2022-08-26

RE: [RFC PATCH] usb: reduce kernel log spam on driver registration

From: "Alim Akhtar" <alim.akhtar@samsung.com>
Date: 2022-08-26 04:02:19
Also in: linux-omap, linux-samsung-soc, linux-usb, lkml

-----Original Message-----
From: Russell King (Oracle) [mailto:linux@armlinux.org.uk]
Sent: Thursday, August 25, 2022 11:40 PM
To: Alim Akhtar <alim.akhtar@samsung.com>
Cc: 'Ard Biesheuvel' <ardb@kernel.org>; linux-kernel@vger.kernel.org;
'Alexandre Belloni' [off-list ref]; linux-samsung-
soc@vger.kernel.org; 'Tomer Maimon' [off-list ref]; linux-
omap@vger.kernel.org; 'Avi Fishman' [off-list ref]; 'Greg
Kroah-Hartman' [off-list ref]; linux-usb@vger.kernel.org;
'Tali Perry' [off-list ref]; 'Nancy Yuen' [off-list ref];
'Krzysztof Kozlowski' [off-list ref]; 'Alan Stern'
[off-list ref]; 'Patrice Chotard'
[off-list ref]; 'Patrick Venture' [off-list ref];
'Vladimir Zapolskiy' [off-list ref]; 'Claudiu Beznea'
[off-list ref]; linux-arm-kernel@lists.infradead.org;
'Benjamin Fair' [off-list ref]
Subject: Re: [RFC PATCH] usb: reduce kernel log spam on driver registration

On Thu, Aug 25, 2022 at 10:53:44PM +0530, Alim Akhtar wrote:
quoted
quoted
Drivers are typically supposed to be quiet unless they are actually
probed,
but
quoted
for some reason, USB host controllers seem to be exempt from this
rule, and happily broadcast their existence into the kernel log at
boot even if the hardware in question is nowhere to be found.

Let's fix that, and remove these pr_info() calls.
How about just change pr_info() to pr_debug() instead?
Do the messages serve a useful purpose that the initcall_debug kernel
parameter (that doesn't require #define DEBUG to be set while compiling and
thus can be used with any kernel) doesn't provide?
Ah, right,  initcall_debug will do the job.
So removing pr_info() from init call looks good.
Thanks.

Hi Ard
Feel free to add 

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

--
RMK's Patch system: https://protect2.fireeye.com/v1/url?k=3b37dc19-
5abcc93c-3b365756-74fe485cbff6-6a25f0b5c8476bae&q=1&e=752dac9b-cfef-
4919-8665-
8a220aac5d96&u=https%3A%2F%2Fwww.armlinux.org.uk%2Fdeveloper%2Fp
atches%2F
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help