Thread (3 messages) 3 messages, 3 authors, 2022-08-23

Re: [PATCH 1/1] cgroup: Fix race condition at rebind_subsystems()

From: Mukesh Ojha <hidden>
Date: 2022-08-23 07:35:15
Also in: cgroups, linux-mediatek, lkml


On 8/23/2022 11:11 AM, Jing-Ting Wu wrote:
quoted hunk ↗ jump to hunk
Root cause:
The rebind_subsystems() is no lock held when move css object from A
list to B list,then let B's head be treated as css node at
list_for_each_entry_rcu().

Solution:
Add grace period before invalidating the removed rstat_css_node.

Reported-by: Jing-Ting Wu <redacted>
Suggested-by: Michal Koutný <mkoutny@suse.com>
Signed-off-by: Jing-Ting Wu <redacted>
Tested-by: Jing-Ting Wu <redacted>
Link: https://lore.kernel.org/linux-arm-kernel/d8f0bc5e2fb6ed259f9334c83279b4c011283c41.camel@mediatek.com/T/ (local)
---
  kernel/cgroup/cgroup.c | 1 +
  1 file changed, 1 insertion(+)
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index ffaccd6373f1..0d0c959966ed 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -1820,6 +1820,7 @@ int rebind_subsystems(struct cgroup_root *dst_root, u16 ss_mask)
  
  		if (ss->css_rstat_flush) {
  			list_del_rcu(&css->rstat_css_node);
+			synchronize_rcu();
  			list_add_rcu(&css->rstat_css_node,
  				     &dcgrp->rstat_css_list);
  		}
Good catch.

Acked-by: Mukesh Ojha <redacted>

-Mukesh


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help