Hi Yilun,

	Please find my response inline.

-----Original Message-----
From: Xu Yilun <yilun.xu@intel.com>
Sent: Tuesday, June 28, 2022 2:10 PM
To: Nava kishore Manne <redacted>
Cc: michal.simek@xilinx.com; hao.wu@intel.com; trix@redhat.com;
mdf@kernel.org; gregkh@linuxfoundation.org; ronak.jain@xilinx.com;
rajan.vaja@xilinx.com; abhyuday.godhasara@xilinx.com;
piyush.mehta@xilinx.com; harsha.harsha@xilinx.com;
lakshmi.sai.krishna.potthuri@xilinx.com; linux-arm-
kernel@lists.infradead.org; linux-kernel@vger.kernel.org; linux-
fpga@vger.kernel.org; git@xilinx.com
Subject: Re: [PATCH v2 3/3] fpga: zynqmp-fpga: Adds status interface

CAUTION: This message has originated from an External Source. Please use
proper judgment and caution when opening attachments, clicking links, or
responding to this email.


On Tue, Jun 21, 2022 at 02:58:33PM +0530, Nava kishore Manne wrote:

quoted

Adds status interface for zynqmp-fpga, It's a read only interface
which allows the user to get the PL status.

Usage:
To read the PL configuration status
        cat /sys/class/fpga_manager/<fpga>/status

Signed-off-by: Nava kishore Manne <redacted>
---
Changes for v2:
              - Updated status messages handling logic as suggested by Xu Yilun.

 drivers/fpga/zynqmp-fpga.c | 53
++++++++++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)

diff --git a/drivers/fpga/zynqmp-fpga.c b/drivers/fpga/zynqmp-fpga.c
index c60f20949c47..e194bba91d3f 100644
--- a/drivers/fpga/zynqmp-fpga.c
+++ b/drivers/fpga/zynqmp-fpga.c

@@ -14,6 +14,19 @@

 /* Constant Definitions */
 #define IXR_FPGA_DONE_MASK   BIT(3)
+#define READ_DMA_SIZE                256U
+
+/* Error Register */
+#define IXR_FPGA_ERR_CRC_ERR         BIT(0)
+#define IXR_FPGA_ERR_SECURITY_ERR    BIT(16)
+
+/* Signal Status Register. For details refer ug570 */
+#define IXR_FPGA_END_OF_STARTUP              BIT(4)
+#define IXR_FPGA_GST_CFG_B           BIT(5)
+#define IXR_FPGA_INIT_B_INTERNAL     BIT(11)
+#define IXR_FPGA_DONE_INTERNAL_SIGNAL        BIT(13)
+
+#define IXR_FPGA_CONFIG_STAT_OFFSET  7U

 /**
  * struct zynqmp_fpga_priv - Private data structure @@ -77,8 +90,48

@@ static enum fpga_mgr_states zynqmp_fpga_ops_state(struct

fpga_manager *mgr)

quoted

      return FPGA_MGR_STATE_UNKNOWN;
 }

+static ssize_t zynqmp_fpga_ops_status(struct fpga_manager *mgr, char
+*buf) {
+     unsigned int *kbuf, reg_val;
+     dma_addr_t dma_addr;
+     ssize_t len = 0;
+     int ret;
+
+     kbuf = dma_alloc_coherent(mgr->dev.parent, READ_DMA_SIZE,
+                               &dma_addr, GFP_KERNEL);
+     if (!kbuf)
+             return -ENOMEM;
+
+     ret = zynqmp_pm_fpga_read(IXR_FPGA_CONFIG_STAT_OFFSET,

dma_addr,

quoted

+                               PM_FPGA_READ_CONFIG_REG, &reg_val);
+     if (ret) {
+             len += sprintf(buf + len, "firmware error\n");
+             goto free_dmabuf;
+     }
+
+     if (reg_val & IXR_FPGA_ERR_CRC_ERR)
+             len += sprintf(buf + len, "reconfig CRC error\n");
+     if (reg_val & IXR_FPGA_ERR_SECURITY_ERR)
+             len += sprintf(buf + len, "reconfig security error\n");
+     if (!(reg_val & IXR_FPGA_INIT_B_INTERNAL))
+             len += sprintf(buf + len, "Device Initialization error\n");
+     if (!(reg_val & IXR_FPGA_DONE_INTERNAL_SIGNAL))
+             len += sprintf(buf + len, "Device internal signal error\n");
+     if (!(reg_val & IXR_FPGA_GST_CFG_B))
+             len += sprintf(buf + len,
+                            "All I/Os are placed in High-Z state\n");
+     if (!(reg_val & IXR_FPGA_END_OF_STARTUP))
+             len += sprintf(buf + len, "Device sequence error\n");

Expressing multiple lines of data is discouraged, one value or an array of
values is OK. For more details, see Documentation/filesystems/sysfs.rst

Will fix.

Regards,
Navakishore.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel