Re: [PATCH 4/9] soc: sunxi: sram: Fix probe function ordering issues
From: Jernej Škrabec <jernej.skrabec@gmail.com>
Date: 2022-08-14 10:34:17
Also in:
linux-devicetree, linux-sunxi, lkml
Dne ponedeljek, 01. avgust 2022 ob 05:05:04 CEST je Samuel Holland napisal(a):
Errors from debugfs are intended to be non-fatal, and should not prevent
the driver from probing.
Since debugfs file creation is treated as infallible, move it below the
parts of the probe function that can fail. This prevents an error
elsewhere in the probe function from causing the file to leak. Do the
same for the call to of_platform_populate().
Finally, checkpatch suggests an octal literal for the file permissions.
Fixes: 4af34b572a85 ("drivers: soc: sunxi: Introduce SoC driver to map
SRAMs") Fixes: 5828729bebbb ("soc: sunxi: export a regmap for EMAC clock
reg on A64") Signed-off-by: Samuel Holland [off-list ref]Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com> Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel