Thread (40 messages) 40 messages, 3 authors, 2022-08-11

Re: [PATCH v4 03/17] perf jevents: Add JEVENTS_ARCH make option

From: Arnaldo Carvalho de Melo <acme@kernel.org>
Date: 2022-08-09 19:39:28
Also in: linux-perf-users, lkml

Em Fri, Aug 05, 2022 at 10:55:50AM +0100, John Garry escreveu:
On 04/08/2022 23:18, Ian Rogers wrote:
quoted
Allow the architecture built into pmu-events.c to be set on the make
command line with JEVENTS_ARCH.

Signed-off-by: Ian Rogers <irogers@google.com>
Seems reasonable, so:

Reviewed-by: John Garry <redacted>
Thanks, applied.

- Arnaldo

 
I assume that if we run on the wrong arch (than we build for) then it has
same effect as if pmu-events is not supported.
quoted
---
  tools/perf/pmu-events/Build | 6 +++++-
  1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tools/perf/pmu-events/Build b/tools/perf/pmu-events/Build
index 28a9d01b08af..04ef95174660 100644
--- a/tools/perf/pmu-events/Build
+++ b/tools/perf/pmu-events/Build
@@ -7,6 +7,10 @@ JSON_TEST	=  $(shell [ -d $(JDIR_TEST) ] &&			\
  			find $(JDIR_TEST) -name '*.json')
  JEVENTS_PY	=  pmu-events/jevents.py
+ifeq ($(JEVENTS_ARCH),)
+JEVENTS_ARCH=$(SRCARCH)
+endif
+
  #
  # Locate/process JSON files in pmu-events/arch/
  # directory and create tables in pmu-events.c.
@@ -19,5 +23,5 @@ $(OUTPUT)pmu-events/pmu-events.c: pmu-events/empty-pmu-events.c
  else
  $(OUTPUT)pmu-events/pmu-events.c: $(JSON) $(JSON_TEST) $(JEVENTS_PY)
  	$(call rule_mkdir)
-	$(Q)$(call echo-cmd,gen)$(PYTHON) $(JEVENTS_PY) $(SRCARCH) pmu-events/arch $@
+	$(Q)$(call echo-cmd,gen)$(PYTHON) $(JEVENTS_PY) $(JEVENTS_ARCH) pmu-events/arch $@
  endif
-- 

- Arnaldo

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help