On 04/08/2022 11:35, John Garry wrote:

quoted

quoted

quoted

          ctrl->cols_index = sdw_find_col_index(data->default_cols);
-#if IS_REACHABLE(CONFIG_SLIMBUS)
-       if (dev->parent->bus == &slimbus_bus) {
-#else
-       if (false) {
-#endif
+       if (IS_ENABLED(CONFIG_SLIMBUS) && dev->parent->bus == 
&slimbus_bus) {
                  ctrl->reg_read = qcom_swrm_ahb_reg_read;
                  ctrl->reg_write = qcom_swrm_ahb_reg_write;
                  ctrl->regmap = dev_get_regmap(dev->parent, NULL);

This relies on the compiler optimizing out the reference to slimbus_bus,
which doesn't exist in the CONFIG_SLIMBUS=n case (not tested, but I
think this means an O0 build will fail?).

That is correct: We rely on this everywhere in the kernel, which is why
it is impossible to build kernels with -O0.

Was there any patch sent to fix/improve this? I could not see any. Or 
any plan to do so?

Since I got no response, I'll assume 'no'. So I'll look to do this when 
I get a chance.

Thanks,
John

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel