On Fri, Aug 5, 2022 at 1:04 AM Nícolas F. R. A. Prado
[off-list ref] wrote:

Hi Balsam,

On Thu, Aug 04, 2022 at 03:09:06PM +0200, bchihi@baylibre.com wrote:

quoted

From: Michael Kao <redacted>

Add MediaTek proprietary folder to upstream more thermal zone and cooler
drivers, relocate the original thermal controller driver to it, and rename it
as "mtxxxx_thermal.c" to show its purpose more clearly.

Signed-off-by: Michael Kao <redacted>
Signed-off-by: Ben Tseng <redacted>
Signed-off-by: Balsam CHIHI <redacted>
---
 drivers/thermal/Kconfig                       | 14 ++++-------
 drivers/thermal/Makefile                      |  2 +-
 drivers/thermal/mediatek/Kconfig              | 23 +++++++++++++++++++
 drivers/thermal/mediatek/Makefile             |  1 +
 .../mtxxxx_thermal.c}                         |  2 +-
 5 files changed, 30 insertions(+), 12 deletions(-)
 create mode 100644 drivers/thermal/mediatek/Kconfig
 create mode 100644 drivers/thermal/mediatek/Makefile
 rename drivers/thermal/{mtk_thermal.c => mediatek/mtxxxx_thermal.c} (99%)

[..]

quoted

--- /dev/null
+++ b/drivers/thermal/mediatek/Makefile

@@ -0,0 +1 @@
+obj-$(CONFIG_MTK_SOC_THERMAL)                += mtxxxx_thermal.o

diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mediatek/mtxxxx_thermal.c

When Daniel suggested using a more SoC explicit name like 'mtxxx_thermal' [1]
the xxxx was supposed to be substituted for the actual SoC (family) that makes
use of this driver :-).

From the compatibles looks like we have mt8173, mt2701, mt2712, mt7622, mt8183.
So it doesn't look like it's a single SoC family... What about calling it
auxadc_thermal?

Thanks,
Nícolas

Hello Nícolas,

"auxadc_thermal.c" makes more sense, since we have "lvts_thermal.c".
Thank you for the suggestion. I will take it.

Best regards,
Balsam

[1] https://lore.kernel.org/linux-mediatek/24250d03-b25f-e521-5abd-f36109885c36@linaro.org/ (local)

quoted

similarity index 99%
rename from drivers/thermal/mtk_thermal.c
rename to drivers/thermal/mediatek/mtxxxx_thermal.c
index ede94eadddda..60924f8f98e9 100644

--- a/drivers/thermal/mtk_thermal.c
+++ b/drivers/thermal/mediatek/mtxxxx_thermal.c

@@ -23,7 +23,7 @@
 #include <linux/reset.h>
 #include <linux/types.h>

-#include "thermal_hwmon.h"
+#include "../thermal_hwmon.h"

 /* AUXADC Registers */
 #define AUXADC_CON1_SET_V    0x008
--

2.34.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel