Re: [PATCH 5/5] ARM: stacktrace: Convert stacktrace to generic ARCH_STACKWALK
From: Li Huafei <hidden>
Date: 2022-07-27 06:29:39
Also in:
linux-perf-users, lkml
Hi Linus, On 2022/7/18 17:12, Linus Walleij wrote:
On Tue, Jul 12, 2022 at 4:19 AM Li Huafei [off-list ref] wrote:quoted
This patch converts ARM stacktrace to the generic ARCH_STACKWALK implemented by commit 214d8ca6ee85 ("stacktrace: Provide common infrastructure"). Signed-off-by: Li Huafei <redacted>Looks good to me: Reviewed-by: Linus Walleij <redacted> What I want to know is if this commit will avoid the problem mentioned in review of commit 3? I.e. the generic stackwalk code will make sure we are not running the task on another CPU, so that is why we could remove that check?
In v3, I removed patch 3 of v1 and kept that check, see https://lore.kernel.org/lkml/20220727040022.139387-1-lihuafei1@huawei.com/ (local) Given this change, I did not add your reviewed-by to patch 4 of v3. If you think patch 4 of v3 is still ok, please do let me know. Thank you very much! Thanks, Huafei
Yours, Linus Walleij .
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel