Hi Rob,

On Wed, Jul 20, 2022 at 05:39:06PM -0600, Rob Herring wrote:

On Tue, Jul 19, 2022 at 11:17:32AM +0200, Jerome Neanne wrote:

quoted

From: Markus Schneider-Pargmann <msp@baylibre.com>

Add a power-button property to configure the EN/PB/VSENSE pin as a
powerbutton.

Belongs in the first binding patch.

quoted

Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
Signed-off-by: Jerome Neanne <redacted>
---
 Documentation/devicetree/bindings/regulator/ti,tps65219.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml b/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml
index 6a60e62a313c..3f7f4c0280c3 100644
--- a/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml
+++ b/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml

@@ -36,6 +36,11 @@ properties:
       include/dt-bindings/interrupt-controller/irq.h
     const: 1
 
+  power-button:

ti,power-button

Though doesn't 'system-power-controller' imply this?

No, there is a difference between system-power-controller and
power-button. If you ask, my description is probably not clear enough.
Let me try a new one:

TPS65219 has a multipurpose pin called EN/PB/VSENSE that can be either
EN in which case it functions as an enable pin. It can be VSENSE which
compares the voltages and triggers an automatic on/off request. And it
can be PB in which case it can be configured to trigger an interrupt to
the SoC. ti,power-button reflects exactly the last one of those options
where the board has a button wired to the pin and triggers an interrupt
on pressing it.

I hope that answers your question. We will fix the description in v2.

Thanks,
Markus

quoted

+    type: boolean
+    description: Optional property that sets the EN/PB/VSENSE pin to be a
+      power-button.
+
 patternProperties:
   "^buck[1-3]-supply$":
     description: Input supply phandle of one regulator.
-- 
2.17.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel