Re: [PATCH v6 09/21] arch_topology: Add support to parse and detect cache attributes
From: Sudeep Holla <hidden>
Date: 2022-07-19 15:05:32
Also in:
linux-riscv, lkml
On Tue, Jul 19, 2022 at 03:37:22PM +0100, Conor Dooley wrote:
On 19/07/2022 15:22, Geert Uytterhoeven wrote:quoted
Hi Sudeep,Hey Geert,
[...]
quoted
This is triggered Early cacheinfo failed, ret = -12 on all my RV64 platforms (K210, PolarFire, StarLight).This should be fixed by Sudeeps most recent patchset, at least it was when I tested it! https://lore.kernel.org/all/20220713133344.1201247-1-sudeep.holla@arm.com/ (local)
Conor you beat me in the response speed :).
quoted
-12 = -ENOMEM. The boot continues regardless, and the K210 even has enough spare RAM after boot to run "ls", unlike two weeks ago ;-)
Yes Conor initially reported this and I suspected something to do with per-cpu allocation as the early cacheinfo failed but succeeded in device initcall level. However when fixing some hotplug issue, I moved the detection of cache attributes on all cpus from boot cpu to individual CPUs in the secondary startup which seem to fix the issue as I assume the per-cpu allocation is ready to use at that stage. However we still have one pending issue[0] to address even after [1], but that doesn't affect DT platforms. -- Regards, Sudeep [0] https://lore.kernel.org/all/20220718174151.GA462603@roeck-us.net/ (local) [1] https://lore.kernel.org/all/20220715102609.2160689-1-sudeep.holla@arm.com/ (local) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel