Thread (61 messages) 61 messages, 5 authors, 2022-07-14

Re: [PATCH v1 02/16] dt-bindings: memory: mediatek: Update condition for mt8195 smi node

From: Tinghan Shen <hidden>
Date: 2022-07-06 03:59:56
Also in: linux-devicetree, linux-iommu, linux-mediatek, lkml

On Mon, 2022-07-04 at 12:25 +0200, AngeloGioacchino Del Regno wrote:
Il 04/07/22 12:00, Tinghan Shen ha scritto:
quoted
The max clock items for the dts node with compatible
'mediatek,mt8195-smi-sub-common' should be 3.

However, the dtbs_check of such node will get following message,
arch/arm64/boot/dts/mediatek/mt8195-evb.dtb: smi@14010000: clock-names: ['apb', 'smi', 'gals0']
is too long
          From schema: Documentation/devicetree/bindings/memory-controllers/mediatek,smi-
common.yaml

Remove the last 'else' checking to fix this error.

Signed-off-by: Tinghan Shen <redacted>
---
  .../memory-controllers/mediatek,smi-common.yaml        | 10 +++++++++-
  1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
index a98b359bf909..e5f553e2e12a 100644
--- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
+++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
@@ -143,7 +143,15 @@ allOf:
              - const: gals0
              - const: gals1
  
-    else:  # for gen2 HW that don't have gals
+  - if:  # for gen2 HW that don't have gals
+      properties:
+        compatible:
+          enum:
+            - mediatek,mt2712-smi-common
MT6795 also doesn't have any GALS, please add it in here.
Ok, I'll update it in next version.

Thanks,
TingHan


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help