Re: [PATCH] arm64: dts: juno: Add cache-level property to L2 caches
From: Liviu Dudau <liviu.dudau@arm.com>
Date: 2022-06-29 10:20:40
On Wed, Jun 29, 2022 at 10:59:59AM +0100, Sudeep Holla wrote:
Add the missing cache-level property to L2 caches. This is needed if we need to find the last level cache directly from the device tree cache node. Cc: Liviu Dudau <liviu.dudau@arm.com> Cc: Lorenzo Pieralisi <lpieralisi@kernel.org> Signed-off-by: Sudeep Holla <redacted>
Acked-by: Liviu Dudau <liviu.dudau@arm.com> Thanks for the useful addition! Best regards, Liviu
quoted hunk ↗ jump to hunk
--- arch/arm64/boot/dts/arm/juno-r1.dts | 2 ++ arch/arm64/boot/dts/arm/juno-r2.dts | 2 ++ arch/arm64/boot/dts/arm/juno.dts | 2 ++ 3 files changed, 6 insertions(+) Hi, I found out that of_find_last_cache_level() was returning 0 for L2 cache on juno when I was attempting to use of_find_last_cache_level() during the rework of my {arch,cache_topology} series[1], although I ended up not using that function at the end. Regards, Sudeep [1] https://lore.kernel.org/all/20220627165047.336669-1-sudeep.holla@arm.com/ (local)diff --git a/arch/arm64/boot/dts/arm/juno-r1.dts b/arch/arm64/boot/dts/arm/juno-r1.dts index f099fb611d4e..6451c62146fd 100644 --- a/arch/arm64/boot/dts/arm/juno-r1.dts +++ b/arch/arm64/boot/dts/arm/juno-r1.dts@@ -192,6 +192,7 @@ A57_L2: l2-cache0 { cache-size = <0x200000>; cache-line-size = <64>; cache-sets = <2048>; + cache-level = <2>; }; A53_L2: l2-cache1 {@@ -199,6 +200,7 @@ A53_L2: l2-cache1 { cache-size = <0x100000>; cache-line-size = <64>; cache-sets = <1024>; + cache-level = <2>; }; };diff --git a/arch/arm64/boot/dts/arm/juno-r2.dts b/arch/arm64/boot/dts/arm/juno-r2.dts index 709389582ae3..438cd1ff4bd0 100644 --- a/arch/arm64/boot/dts/arm/juno-r2.dts +++ b/arch/arm64/boot/dts/arm/juno-r2.dts@@ -198,6 +198,7 @@ A72_L2: l2-cache0 { cache-size = <0x200000>; cache-line-size = <64>; cache-sets = <2048>; + cache-level = <2>; }; A53_L2: l2-cache1 {@@ -205,6 +206,7 @@ A53_L2: l2-cache1 { cache-size = <0x100000>; cache-line-size = <64>; cache-sets = <1024>; + cache-level = <2>; }; };diff --git a/arch/arm64/boot/dts/arm/juno.dts b/arch/arm64/boot/dts/arm/juno.dts index dbc22e70b62c..cf4a58211399 100644 --- a/arch/arm64/boot/dts/arm/juno.dts +++ b/arch/arm64/boot/dts/arm/juno.dts@@ -197,6 +197,7 @@ A57_L2: l2-cache0 { cache-size = <0x200000>; cache-line-size = <64>; cache-sets = <2048>; + cache-level = <2>; }; A53_L2: l2-cache1 {@@ -204,6 +205,7 @@ A53_L2: l2-cache1 { cache-size = <0x100000>; cache-line-size = <64>; cache-sets = <1024>; + cache-level = <2>; }; };-- 2.37.0
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel