Re: [PATCH v2 1/7] media: Add P010 tiled format
From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Date: 2022-06-28 19:05:48
Also in:
linux-media, linux-rockchip, linux-staging, lkml
Hi Jernej, Thanks for the patch. On Thu, Jun 16, 2022 at 10:25:07PM +0200, Jernej Skrabec wrote:
From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> Add P010 tiled format Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> [rebased and updated pixel format name] Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com> --- drivers/media/v4l2-core/v4l2-common.c | 1 + drivers/media/v4l2-core/v4l2-ioctl.c | 1 + include/uapi/linux/videodev2.h | 1 +
We also need to add the documentation in
Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst.
See Benjamin's patch for reference:
commit 5374d8fb75f313294c7d97e85c22bead34d63f2b
Author: Benjamin Gaignard [off-list ref]
Date: Thu May 19 08:11:46 2022 +0100
media: Add P010 video format
P010 is a YUV format with 10-bits per component with interleaved UV.
quoted hunk ↗ jump to hunk
3 files changed, 3 insertions(+)diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2-core/v4l2-common.c index 1e38ad8906a2..e0fbe6ba4b6c 100644 --- a/drivers/media/v4l2-core/v4l2-common.c +++ b/drivers/media/v4l2-core/v4l2-common.c@@ -278,6 +278,7 @@ const struct v4l2_format_info *v4l2_format_info(u32 format) /* Tiled YUV formats */ { .format = V4L2_PIX_FMT_NV12_4L4, .pixel_enc = V4L2_PIXEL_ENC_YUV, .mem_planes = 1, .comp_planes = 2, .bpp = { 1, 2, 0, 0 }, .hdiv = 2, .vdiv = 2 }, + { .format = V4L2_PIX_FMT_P010_4L4, .pixel_enc = V4L2_PIXEL_ENC_YUV, .mem_planes = 1, .comp_planes = 2, .bpp = { 2, 4, 0, 0 }, .hdiv = 2, .vdiv = 2 }, /* YUV planar formats, non contiguous variant */ { .format = V4L2_PIX_FMT_YUV420M, .pixel_enc = V4L2_PIXEL_ENC_YUV, .mem_planes = 3, .comp_planes = 3, .bpp = { 1, 1, 1, 0 }, .hdiv = 2, .vdiv = 2 },diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c index e2526701294e..e24d38c0a178 100644 --- a/drivers/media/v4l2-core/v4l2-ioctl.c +++ b/drivers/media/v4l2-core/v4l2-ioctl.c@@ -1310,6 +1310,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt) case V4L2_PIX_FMT_NV12_4L4: descr = "Y/CbCr 4:2:0 (4x4 Linear)"; break; case V4L2_PIX_FMT_NV12_16L16: descr = "Y/CbCr 4:2:0 (16x16 Linear)"; break; case V4L2_PIX_FMT_NV12_32L32: descr = "Y/CbCr 4:2:0 (32x32 Linear)"; break; + case V4L2_PIX_FMT_P010_4L4: descr = "P010 tiled"; break;
I would make this "10-bit Y/CbCr 4:2:0 (4x4 Linear)". Thanks, Ezequiel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel