Thread (19 messages) 19 messages, 5 authors, 2022-06-27

Re: [PATCH v3 2/7] dt-bindings: clock: Add MediaTek Helio X10 MT6795 clock bindings

From: Krzysztof Kozlowski <hidden>
Date: 2022-06-27 09:00:06
Also in: linux-clk, linux-devicetree, linux-mediatek, lkml, phone-devel

On 27/06/2022 10:49, AngeloGioacchino Del Regno wrote:
Il 25/06/22 22:30, Krzysztof Kozlowski ha scritto:
quoted
On 24/06/2022 11:35, AngeloGioacchino Del Regno wrote:
quoted
Add the bindings for MT6795's clock controller.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Acked-by: Rob Herring <robh@kernel.org>
---
  include/dt-bindings/clock/mt6795-clk.h | 275 +++++++++++++++++++++++++
  1 file changed, 275 insertions(+)
  create mode 100644 include/dt-bindings/clock/mt6795-clk.h
diff --git a/include/dt-bindings/clock/mt6795-clk.h b/include/dt-bindings/clock/mt6795-clk.h
new file mode 100644
index 000000000000..9902906ac902
--- /dev/null
+++ b/include/dt-bindings/clock/mt6795-clk.h
Vendor prefix.
For consistency, I'd really like to keep the filename as it is.

At least in this directory, all of the MediaTek clock bindings
are using the format mtXXXX-clk.h... and that's not only seen
in MediaTek, but also in Broadcom, Renesas, RockChip, HiSilicon,
nVidia, etc.
Several new files are introduced with vendor prefix. The same as in
bindings - old bindings were without vendor, so for consistency we would
never switch to vendor one.

For consistency with Documentation/devicetree/bindings and with all new
files in binding headers, please add vendor prefix.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help