Hi Andy,

Thanks for your helpful comments!

Andy Shevchenko [off-list ref] 於 2022年6月24日 週五 凌晨2:19寫道：

On Thu, Jun 23, 2022 at 2:00 PM ChiaEn Wu [off-list ref] wrote:

quoted

From: ChiYuan Huang <redacted>

Add mt6370 DisplayBias and VibLDO support.

...

quoted

+#include <linux/bits.h>
+#include <linux/gpio/consumer.h>
+#include <linux/interrupt.h>
+#include <linux/kernel.h>
+#include <linux/module.h>

quoted

+#include <linux/of.h>

Any users of this? (See below)

quoted

+#include <linux/platform_device.h>
+#include <linux/regmap.h>
+#include <linux/regulator/driver.h>
+#include <linux/regulator/machine.h>

...

quoted

+#define MT6370_LDO_MINUV       1600000
+#define MT6370_LDO_STPUV       200000
+#define MT6370_LDO_N_VOLT      13
+#define MT6370_DBVBOOST_MINUV  4000000
+#define MT6370_DBVBOOST_STPUV  50000
+#define MT6370_DBVBOOST_N_VOLT 45
+#define MT6370_DBVOUT_MINUV    4000000
+#define MT6370_DBVOUT_STPUV    50000
+#define MT6370_DBVOUT_N_VOLT   41

If UV is a unit suffix, make it _UV.

...

quoted

+               .of_match = of_match_ptr("dsvbst"),

Would it even be called / used if CONFIG_OF=n?

We got a notification from Mark telling us that this patch has been
applied to git.
( https://lore.kernel.org/linux-arm-kernel/165599931844.321775.8085559092337130067.b4-ty@kernel.org/ (local)
)
So, should we need to make any other changes in the next submission?

...

quoted

+               .regulators_node = of_match_ptr("regulators"),

Ditto.

...

quoted

+       for (i = 0; i < ARRAY_SIZE(mt6370_irqs); i++) {
+               irq = platform_get_irq_byname(pdev, mt6370_irqs[i].name);
+
+               rdev = priv->rdev[mt6370_irqs[i].rid];
+
+               ret = devm_request_threaded_irq(priv->dev, irq, NULL,
+                                               mt6370_irqs[i].handler, 0,
+                                               mt6370_irqs[i].name, rdev);
+               if (ret) {

quoted

+                       dev_err(priv->dev,
+                               "Failed to register (%d) interrupt\n", i);
+                       return ret;

return dev_err_probe(...); ?

quoted

+               }
+       }

...

quoted

+       for (i = 0; i < MT6370_MAX_IDX; i++) {
+               rdev = devm_regulator_register(priv->dev,
+                                              mt6370_regulator_descs + i,
+                                              &cfg);
+               if (IS_ERR(rdev)) {

quoted

+                       dev_err(priv->dev,
+                               "Failed to register (%d) regulator\n", i);
+                       return PTR_ERR(rdev);

return dev_err_probe(...); ?

quoted

+               }
+
+               priv->rdev[i] = rdev;
+       }

...

quoted

+       if (!priv->regmap) {
+               dev_err(&pdev->dev, "Failed to init regmap\n");
+               return -ENODEV;
+       }

return dev_err_probe(...);

--
With Best Regards,
Andy Shevchenko

Best regards,
ChiaEn Wu

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel