Re: [PATCH v2 5/5] vfio/iommu_type1: Simplify group attachment

From
Robin Murphy <robin.murphy@arm.com>
Date
2022-06-20 10:11:15
Also in
kvm, linux-arm-msm, linux-iommu, linux-mediatek, linux-s390, linux-tegra, lkml, virtualization
Reply to
Tian, Kevin, 2022-06-17
On 2022-06-17 03:53, Tian, Kevin wrote:
quoted
From: Nicolin Chen <redacted>
Sent: Friday, June 17, 2022 6:41 AM
quoted
...
quoted
-     if (resv_msi) {
+     if (resv_msi && !domain->msi_cookie) {
               ret = iommu_get_msi_cookie(domain->domain,
resv_msi_base);
               if (ret && ret != -ENODEV)
                       goto out_detach;
+             domain->msi_cookie = true;
       }
why not moving to alloc_attach_domain() then no need for the new
domain field? It's required only when a new domain is allocated.
When reusing an existing domain that doesn't have an msi_cookie,
we can do iommu_get_msi_cookie() if resv_msi is found. So it is
not limited to a new domain.
Looks msi_cookie requirement is per platform (currently only
for smmu. see arm_smmu_get_resv_regions()). If there is
no mixed case then above check is not required.

But let's hear whether Robin has a different thought here.
Yes, the cookie should logically be tied to the lifetime of the domain itself. In the relevant context, "an existing domain that doesn't have an msi_cookie" should never exist.

Thanks,
Robin.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thread (30 messages) 30 messages, 6 authors, last reply 2022-06-24
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help