Thread (31 messages) 31 messages, 3 authors, 2022-06-21

Re: [PATCH v3 07/18] dt-bindings: reset: npcm: add GCR syscon property

From: Tomer Maimon <tmaimon77@gmail.com>
Date: 2022-06-20 08:49:41
Also in: linux-clk, linux-devicetree, linux-serial, linux-watchdog, lkml

Hi Krzysztof,

On Mon, 20 Jun 2022 at 11:22, Krzysztof Kozlowski
[off-list ref] wrote:
On 19/06/2022 17:12, Tomer Maimon wrote:
quoted
Describe syscon property that handles general control registers (GCR) in
Nuvoton BMC NPCM reset driver.

Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
---
 .../devicetree/bindings/reset/nuvoton,npcm750-reset.yaml     | 5 +++++
 1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/reset/nuvoton,npcm750-reset.yaml b/Documentation/devicetree/bindings/reset/nuvoton,npcm750-reset.yaml
index fa5e4ea6400e..7ba3a6ff82ed 100644
--- a/Documentation/devicetree/bindings/reset/nuvoton,npcm750-reset.yaml
+++ b/Documentation/devicetree/bindings/reset/nuvoton,npcm750-reset.yaml
@@ -19,6 +19,9 @@ properties:
   '#reset-cells':
     const: 2

+  nuvoton,sysgcr:
+    description: a phandle to access GCR registers.
That's not valid. You miss here ref. My comment was to skip quotes and
you removed entire ref.
Will add the ref next version.
Best regards,
Krzysztof
Best regards,

Tomer

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help