Re: [PATCH v11 05/10] drm/mediatek: Add MT8195 Embedded DisplayPort driver
flat view
From: CK Hu <hidden>
Date: 2022-06-20 03:46:33
Also in:
dri-devel, linux-devicetree, linux-fbdev, linux-mediatek, lkml
Hi, Rex: On Fri, 2022-06-10 at 18:55 +0800, Bo-Chen Chen wrote:
From: Markus Schneider-Pargmann <msp@baylibre.com> This patch adds a embedded displayport driver for the MediaTek mt8195 SoC. It supports the MT8195, the embedded DisplayPort units. It offers DisplayPort 1.4 with up to 4 lanes. The driver creates a child device for the phy. The child device will never exist without the parent being active. As they are sharing a register range, the parent passes a regmap pointer to the child so that both can work with the same register range. The phy driver sets device data that is read by the parent to get the phy device that can be used to control the phy properties. This driver is based on an initial version by Jitao shi [off-list ref] Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com> Signed-off-by: Guillaume Ranquet <redacted> [Bo-Chen: Cleanup the drivers and modify comments from reviewers] Signed-off-by: Bo-Chen Chen <redacted> ---
[snip]
quoted hunk ↗ jump to hunk
+ +static void mtk_dp_poweroff(struct mtk_dp *mtk_dp) +{ + mutex_lock(&mtk_dp->dp_lock); + + mtk_dp_hwirq_enable(mtk_dp, false); + mtk_dp_power_disable(mtk_dp); + phy_exit(mtk_dp->phy); + + mutex_unlock(&mtk_dp->dp_lock); +} + +static int mtk_dp_poweron(struct mtk_dp *mtk_dp) +{ + int ret = 0; + + mutex_lock(&mtk_dp->dp_lock);
The dp_poweron/off is only called by bridge_attach/detach, and I think drm core would not call attach/detach concurrently, so this mutex is redundant. Remove it. Regards, CK
+
+ ret = phy_init(mtk_dp->phy);
+ if (ret) {
+ dev_err(mtk_dp->dev, "Failed to initialize phy: %d\n",
ret);
+ goto err_phy_init;
+ }
+ ret = mtk_dp_phy_configure(mtk_dp, MTK_DP_LINKRATE_RBR, 1);
+ if (ret) {
+ dev_err(mtk_dp->dev, "Failed to configure phy: %d\n",
ret);
+ goto err_phy_config;
+ }
+
+ mtk_dp_init_port(mtk_dp);
+ mtk_dp_power_enable(mtk_dp);
+
+err_phy_config:
+ phy_exit(mtk_dp->phy);
+err_phy_init:
+ mutex_unlock(&mtk_dp->dp_lock);
+ return ret;
+}_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel