Thread (7 messages) 7 messages, 2 authors, 2022-06-13

Re: [PATCH v4 1/3] media: dt-binding: media: Add rockchip-vepu binding

From: Krzysztof Kozlowski <hidden>
Date: 2022-06-13 09:44:13
Also in: linux-devicetree, linux-media, linux-rockchip, lkml

On 12/06/2022 17:05, Nicolas Frattaroli wrote:
quoted
quoted
+
+  clock-names:
+    items:
+      - const: aclk
+      - const: hclk
Since these are new bindings, it would be good to follow DT convention
and not add common "clk" prefix to clocks. Just like DMA is "tx" not
"txdma". However clock names "a" and "h" are also not good and maybe
this is already shared implementation?
This is indeed a shared implementation. Theoretically I could change
the driver for this one case but that seems pointless, especially
since "aclk" and "hclk" are the usual clk names for AXI and AHB on
ARM as far as I understand. I think I've been told before that those
two clocks should always be called aclk and hclk.
ok


Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help