Re: [PATCH 2/3] dt-bindings: usb: atmel: Add Microchip LAN966x compatible string
From: Krzysztof Kozlowski <hidden>
Date: 2022-05-20 11:40:37
Also in:
linux-clk, linux-devicetree, linux-usb, lkml
On 20/05/2022 13:34, Herve Codina wrote:
On Fri, 13 May 2022 14:57:55 +0200 Krzysztof Kozlowski [off-list ref] wrote:quoted
On 13/05/2022 12:58, Herve Codina wrote:quoted
The USB device controller available in the Microchip LAN966x SOC is the same IP as the one present in the SAMA5D3 SOC. Add the LAN966x compatible string and set the SAMA5D3 compatible string as a fallback for the LAN966x. Signed-off-by: Herve Codina <herve.codina@bootlin.com> --- Documentation/devicetree/bindings/usb/atmel-usb.txt | 3 +++ 1 file changed, 3 insertions(+)diff --git a/Documentation/devicetree/bindings/usb/atmel-usb.txt b/Documentation/devicetree/bindings/usb/atmel-usb.txt index f512f0290728..a6fab7d63f37 100644 --- a/Documentation/devicetree/bindings/usb/atmel-usb.txt +++ b/Documentation/devicetree/bindings/usb/atmel-usb.txt@@ -87,6 +87,9 @@ Required properties: "atmel,at91sam9g45-udc" "atmel,sama5d3-udc" "microchip,sam9x60-udc" + "microchip,lan996x-udc"No wildcards please, especially that it closely fits previous wildcard (lan996x includes lan9960 which looks a lot like sam9x60...)Well, first, I made a mistake. It should be lan966x instead of lan996x. This family is composed of the LAN9662 and the LAN9668 SOCs. Related to the wilcard, lan966x is used in several bindings for common parts used by both SOCs: - microchip,lan966x-gck - microchip,lan966x-cpu-syscon - microchip,lan966x-switch - microchip,lan966x-miim - microchip,lan966x-serdes - microchip,lan966x-pinctrl
And for new bindings I pointed that it is not preferred, so already few other started using specific compatible.
I think it makes sense to keep 'microchip,lan966x-udc' for the USB device controller (same controller on LAN9662 and LAN9668) and so keeping the same rules as for other common parts.
Having wildcard was rather a mistake and we already started correcting it, so keeping the "mistake" neither gives you consistency, nor correctness... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel