[PATCH 3/9] serial: rda-uart: Don't allow CS5-6
flat view
DORMANTno replies
SUPERSEDED
From: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Date: 2022-05-17 11:08:28
Also in:
linux-serial, lkml
Subsystem:
arm/rda micro architecture, the rest, tty layer and serial drivers · Maintainers:
Manivannan Sadhasivam, Linus Torvalds, Greg Kroah-Hartman, Jiri Slaby
Revision v1 of 2 in this series.
Revisions (2)
- v1 current
- v2 [diff vs current]
Only CS7 and CS8 are supported but CSIZE is not sanitized after fallthrough from CS5 or CS6 to CS7. Set CSIZE correctly so that userspace knows the effective value. Incorrect CSIZE also results in miscalculation of the frame bits in tty_get_char_size() or in its predecessor where the roughly the same code is directly within uart_update_timeout(). Cc: Manivannan Sadhasivam <mani@kernel.org> Fixes: c10b13325ced (tty: serial: Add RDA8810PL UART driver) Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> --- drivers/tty/serial/rda-uart.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/tty/serial/rda-uart.c b/drivers/tty/serial/rda-uart.c
index e5f1fded423a..f556b4955f59 100644
--- a/drivers/tty/serial/rda-uart.c
+++ b/drivers/tty/serial/rda-uart.c@@ -262,6 +262,8 @@ static void rda_uart_set_termios(struct uart_port *port, fallthrough; case CS7: ctrl &= ~RDA_UART_DBITS_8; + termios->c_cflag &= ~CSIZE; + termios->c_cflag |= CS7; break; default: ctrl |= RDA_UART_DBITS_8;
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel