Re: [PATCH] ARM: milbeaut: Fix refcount leak in m10v_smp_init
From: Sugaya Taichi <sugaya.taichi@socionext.com>
Date: 2022-05-13 06:52:04
Also in:
lkml
Thank you for the patch! Acked-by: Sugaya Taichi <sugaya.taichi@socionext.com> On 2022/05/12 17:15, Miaoqian Lin wrote:
quoted hunk ↗ jump to hunk
of_find_compatible_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. Add missing of_node_put() to avoid refcount leak. Fixes: 9fb29c734f9e ("ARM: milbeaut: Add basic support for Milbeaut m10v SoC") Signed-off-by: Miaoqian Lin <redacted> --- arch/arm/mach-milbeaut/platsmp.c | 1 + 1 file changed, 1 insertion(+)diff --git a/arch/arm/mach-milbeaut/platsmp.c b/arch/arm/mach-milbeaut/platsmp.c index 3ea880f5fcb7..1f1ff21c7140 100644 --- a/arch/arm/mach-milbeaut/platsmp.c +++ b/arch/arm/mach-milbeaut/platsmp.c@@ -53,6 +53,7 @@ static void m10v_smp_init(unsigned int max_cpus) return; m10v_smp_base = of_iomap(np, 0); + of_node_put(np); if (!m10v_smp_base) return;
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel