Re: [PATCH v14 1/3] dt-binding: mediatek: add bindings for MediaTek MDP3 components
From: Rob Herring <robh@kernel.org>
Date: 2022-05-03 17:47:17
Also in:
linux-devicetree, linux-media, linux-mediatek, lkml
On Wed, Apr 27, 2022 at 03:05:12PM +0800, Moudy Ho wrote:
quoted hunk ↗ jump to hunk
This patch adds DT binding documents for Media Data Path 3 (MDP3) a unit in multimedia system combined with several components and used for scaling and color format convert. Signed-off-by: Moudy Ho <redacted> --- .../bindings/media/mediatek,mdp3-rdma.yaml | 82 +++++++++++++++++++ .../bindings/media/mediatek,mdp3-rsz.yaml | 61 ++++++++++++++ .../bindings/media/mediatek,mdp3-wrot.yaml | 66 +++++++++++++++ .../bindings/soc/mediatek/mediatek,ccorr.yaml | 54 ++++++++++++ .../bindings/soc/mediatek/mediatek,wdma.yaml | 67 +++++++++++++++ 5 files changed, 330 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mediatek,ccorr.yaml create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mediatek,wdma.yamldiff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml new file mode 100644 index 000000000000..ce24eda14cb6 --- /dev/null +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml@@ -0,0 +1,82 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/mediatek,mdp3-rdma.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Mediatek Read Direct Memory Access + +maintainers: + - Matthias Brugger <matthias.bgg@gmail.com> + - Ping-Hsun Wu <ping-hsun.wu@mediatek.com> + +description: | + Mediatek Read Direct Memory Access(RDMA) component used to do read DMA. + It contains one line buffer to store the sufficient pixel data, and + must be siblings to the central MMSYS_CONFIG node. + For a description of the MMSYS_CONFIG binding, see + Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml + for details. + +properties: + compatible: + items: + - const: mediatek,mt8183-mdp3-rdma + + reg: + maxItems: 1 + + mediatek,gce-client-reg: + $ref: '/schemas/types.yaml#/definitions/phandle-array' + maxItems: 1
Like your other patches this needs 'items' describing each cell.
+ description: | + The register of client driver can be configured by gce with + 4 arguments defined in this property, such as phandle of gce, subsys id, + register offset and size. Each GCE subsys id is mapping to a client + defined in the header include/dt-bindings/gce/<chip>-gce.h.
Other than other cases of this property, the rest looks fine. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel