On Sat, 2022-04-23 at 18:27 +0800, Krzysztof Kozlowski wrote:

On 22/04/2022 08:01, Rex-BC Chen wrote:

quoted

We will use the infra_ao reset which is defined in mt8192-sys-
clock.
The maximum value of reset-cells is 2. Therefore, we add this patch
to
define it.

Remove entire last sentence, does not make sense in the commit.

Hello Krzysztof,

Thanks for your review.
I will drop "Therefore, we add this patch to define it." and add more
detailed messages in next version.

quoted

Signed-off-by: Rex-BC Chen <redacted>
---
 .../bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml       | 3
+++
 1 file changed, 3 insertions(+)

diff --git
a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-
sys-clock.yaml
b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-
sys-clock.yaml
index 5705bcf1fe47..28ebcecc8258 100644
---
a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-
sys-clock.yaml
+++
b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-
sys-clock.yaml

@@ -29,6 +29,9 @@ properties:
   '#clock-cells':
     const: 1
 
+  '#reset-cells':
+    maximum: 2

Why this is a maximum? Usually this is const, so how do you use it
(with
what values)?

We need to let the driver compatible with previous setting in
drivers/clk/mediatek/reset.c

There are two use cases in our reset driver:
(Refer to [1])

1. #reset-cells = <1>
   When we input the argument, the older driver
use is to calculate  
   bank and bit by different method. From the implementation of
   reset_xlate(), we can see if the argument number is 1, it will
   return directly.

2. #reset-cells = <2>
   The input arguments is offset and bit. When we input two arguments,
   we can use reset_xlate() to calculate the corresponding id to assert
   and deassert.

[1]:
https://lore.kernel.org/all/20220422060152.13534-10-rex-bc.chen@mediatek.com/ (local)

If it's acceptable, I will add this in commit message.

BRs,
Rex

quoted

+
 required:
   - compatible
   - reg

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel