Re: [PATCH v15 00/12] Add Mediatek Soc DRM (vdosys0) support for mt8195

Hi Rob,

Thanks for the reviews.

On Wed, 2022-03-02 at 17:50 -0600, Rob Herring wrote:

On Wed, Jan 26, 2022 at 1:19 AM jason-jh.lin <
jason-jh.lin@mediatek.com> wrote:

quoted

[snip]

quoted

jason-jh.lin (12):
  dt-bindings: arm: mediatek: mmsys: add power and gce properties
  dt-bindings: arm: mediatek: mmsys: add mt8195 SoC binding
  dt-bindings: display: mediatek: disp: split each block to
individual
    yaml
  dt-bindings: display: mediatek: dsc: add yaml for mt8195 SoC
binding
  dt-bindings: display: mediatek: merge: add additional prop for
mt8195
  dt-bindings: display: mediatek: add mt8195 SoC binding for
vdosys0
  dt-bindings: arm: mediatek: move out common module from display
folder
  soc: mediatek: add mtk-mmsys support for mt8195 vdosys0
  soc: mediatek: add mtk-mutex support for mt8195 vdosys0
  drm/mediatek: add DSC support for mediatek-drm
  drm/mediatek: add MERGE support for mediatek-drm
  drm/mediatek: add mediatek-drm of vdosys0 support for mt8195

 .../bindings/arm/mediatek/mediatek,mmsys.yaml |  32 ++-
 .../display/mediatek/mediatek,disp.txt        | 219 --------------
--
 .../display/mediatek/mediatek,dither.yaml     |  76 ++++++
 .../display/mediatek/mediatek,dsc.yaml        |  71 +++++
 .../display/mediatek/mediatek,gamma.yaml      |  77 ++++++
 .../display/mediatek/mediatek,merge.yaml      | 106 ++++++++
 .../display/mediatek/mediatek,od.yaml         |  53 ++++
 .../display/mediatek/mediatek,ovl-2l.yaml     |  88 +++++++
 .../display/mediatek/mediatek,ovl.yaml        | 103 ++++++++
 .../display/mediatek/mediatek,postmask.yaml   |  69 +++++
 .../display/mediatek/mediatek,rdma.yaml       | 117 +++++++++
 .../display/mediatek/mediatek,split.yaml      |  58 +++++
 .../display/mediatek/mediatek,ufoe.yaml       |  61 +++++
 .../bindings/soc/mediatek/mediatek,aal.yaml   |  72 +++++
 .../bindings/soc/mediatek/mediatek,ccorr.yaml |  46 +++-
 .../bindings/soc/mediatek/mediatek,color.yaml |  81 ++++++
 .../bindings/soc/mediatek/mediatek,mutex.yaml |  77 ++++++
 .../bindings/soc/mediatek/mediatek,wdma.yaml  |  47 +++-
 drivers/gpu/drm/mediatek/Makefile             |   1 +
 drivers/gpu/drm/mediatek/mtk_disp_drv.h       |   8 +
 drivers/gpu/drm/mediatek/mtk_disp_merge.c     | 246
++++++++++++++++++
 drivers/gpu/drm/mediatek/mtk_disp_rdma.c      |   6 +
 drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c   |  63 +++++
 drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h   |   2 +
 drivers/gpu/drm/mediatek/mtk_drm_drv.c        |  32 ++-
 drivers/gpu/drm/mediatek/mtk_drm_drv.h        |   1 +
 drivers/soc/mediatek/mt8195-mmsys.h           | 130 +++++++++
 drivers/soc/mediatek/mtk-mmsys.c              |  11 +
 drivers/soc/mediatek/mtk-mutex.c              | 103 +++++++-
 include/linux/soc/mediatek/mtk-mmsys.h        |   9 +
 30 files changed, 1832 insertions(+), 233 deletions(-)
 delete mode 100644
Documentation/devicetree/bindings/display/mediatek/mediatek,disp.tx
t
 create mode 100644
Documentation/devicetree/bindings/display/mediatek/mediatek,dither.
yaml
 create mode 100644
Documentation/devicetree/bindings/display/mediatek/mediatek,dsc.yam
l
 create mode 100644
Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.y
aml
 create mode 100644
Documentation/devicetree/bindings/display/mediatek/mediatek,merge.y
aml
 create mode 100644
Documentation/devicetree/bindings/display/mediatek/mediatek,od.yaml
 create mode 100644
Documentation/devicetree/bindings/display/mediatek/mediatek,ovl-
2l.yaml
 create mode 100644
Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yam
l
 create mode 100644
Documentation/devicetree/bindings/display/mediatek/mediatek,postmas
k.yaml
 create mode 100644
Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.ya
ml
 create mode 100644
Documentation/devicetree/bindings/display/mediatek/mediatek,split.y
aml
 create mode 100644
Documentation/devicetree/bindings/display/mediatek/mediatek,ufoe.ya
ml
 create mode 100644
Documentation/devicetree/bindings/soc/mediatek/mediatek,aal.yaml
 create mode 100644
Documentation/devicetree/bindings/soc/mediatek/mediatek,color.yaml
 create mode 100644
Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml
 create mode 100644 drivers/gpu/drm/mediatek/mtk_disp_merge.c
 create mode 100644 drivers/soc/mediatek/mt8195-mmsys.h

Looks like this is in linux-next and now:

Error:
Documentation/devicetree/bindings/display/mediatek/mediatek,aal.examp
le.dts:27.27-28
syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:386:
Documentation/devicetree/bindings/display/mediatek/mediatek,aal.examp
le.dt.yaml]
Error 1
Error:
Documentation/devicetree/bindings/display/mediatek/mediatek,wdma.exam
ple.dts:27.27-28
syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:386:
Documentation/devicetree/bindings/display/mediatek/mediatek,wdma.exam
ple.dt.yaml]
Error 1
Error:
Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.exa
mple.dts:27.27-28
syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:386:
Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.exa
mple.dt.yaml]
Error 1
Error:
Documentation/devicetree/bindings/display/mediatek/mediatek,dither.ex
ample.dts:27.27-28
syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:386:
Documentation/devicetree/bindings/display/mediatek/mediatek,dither.ex
ample.dt.yaml]
Error 1
Error:
Documentation/devicetree/bindings/display/mediatek/mediatek,postmask.
example.dts:27.27-28
syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:386:
Documentation/devicetree/bindings/display/mediatek/mediatek,postmask.
example.dt.yaml]
Error 1
Error:
Documentation/devicetree/bindings/display/mediatek/mediatek,ufoe.exam
ple.dts:27.27-28
syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:386:
Documentation/devicetree/bindings/display/mediatek/mediatek,ufoe.exam
ple.dt.yaml]
Error 1
Error:
Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.exa
mple.dts:27.27-28
syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:386:
Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.exa
mple.dt.yaml]
Error 1
Error:
Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.exam
ple.dts:27.27-28
syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:386:
Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.exam
ple.dt.yaml]
Error 1
Error:
Documentation/devicetree/bindings/display/mediatek/mediatek,od.exampl
e.dts:24.30-31
syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:386:
Documentation/devicetree/bindings/display/mediatek/mediatek,od.exampl
e.dt.yaml]
Error 1
Error:
Documentation/devicetree/bindings/display/mediatek/mediatek,color.exa
mple.dts:27.27-28
syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:386:
Documentation/devicetree/bindings/display/mediatek/mediatek,color.exa
mple.dt.yaml]
Error 1
Error:
Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.exa
mple.dts:35.50-51
syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:386:
Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.exa
mple.dt.yaml]
Error 1
Error:
Documentation/devicetree/bindings/display/mediatek/mediatek,split.exa
mple.dts:24.35-36
syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:386:
Documentation/devicetree/bindings/display/mediatek/mediatek,split.exa
mple.dt.yaml]
Error 1
Error:
Documentation/devicetree/bindings/display/mediatek/mediatek,merge.exa
mple.dts:27.35-36
syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:386:
Documentation/devicetree/bindings/display/mediatek/mediatek,merge.exa
mple.dt.yaml]
Error 1
Error:
Documentation/devicetree/bindings/display/mediatek/mediatek,mutex.exa
mple.dts:27.27-28
syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:386:
Documentation/devicetree/bindings/display/mediatek/mediatek,mutex.exa
mple.dt.yaml]
Error 1
Error:
Documentation/devicetree/bindings/display/mediatek/mediatek,dsc.examp
le.dts:27.27-28
syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:386:
Documentation/devicetree/bindings/display/mediatek/mediatek,dsc.examp
le.dt.yaml]
Error 1
Error:
Documentation/devicetree/bindings/display/mediatek/mediatek,ovl-
2l.example.dts:27.27-28
syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:386:
Documentation/devicetree/bindings/display/mediatek/mediatek,ovl-
2l.example.dt.yaml]
Error 1
Error:
Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.examp
le.dts:27.27-28
syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:386:
Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.examp
le.dt.yaml]
Error 1

Please fix 'make dt_binding_check'.

Rob

-- 

I'll fix it at the next version.

Jason-JH Lin [off-list ref]


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel