Re: [PATCH v4 2/2] dt-bindings: mmc: xenon: Convert to JSON schema

Hi Rob,

On 31/03/22 03:40, Rob Herring wrote:

On Tue, Mar 29, 2022 at 07:50:59PM +0000, Chris Packham wrote:

quoted

On 30/03/22 02:14, Krzysztof Kozlowski wrote:

quoted

On 29/03/2022 13:50, Rob Herring wrote:

quoted

On Tue, 29 Mar 2022 13:02:31 +1300, Chris Packham wrote:

quoted

Convert the marvell,xenon-sdhci binding to JSON schema. Currently the
in-tree dts files don't validate because they use sdhci@ instead of mmc@
as required by the generic mmc-controller schema.

The compatible "marvell,sdhci-xenon" was not documented in the old
binding but it accompanies the of "marvell,armada-3700-sdhci" in the
armada-37xx SoC dtsi so this combination is added to the new binding
document.

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
---

Notes:
      Changes in v4:
      - Add review from Krzysztof
      - Squash in addition of marvell,sdhci-xenon with an explanation in the
        commit message
      Changes in v3:
      - Don't accept ap807 without ap806
      - Add ref: string for pad-type
      Changes in v2:
      - Update MAINTAINERS entry
      - Incorporate feedback from Krzysztof

   .../bindings/mmc/marvell,xenon-sdhci.txt      | 173 -----------
   .../bindings/mmc/marvell,xenon-sdhci.yaml     | 275 ++++++++++++++++++
   MAINTAINERS                                   |   2 +-
   3 files changed, 276 insertions(+), 174 deletions(-)
   delete mode 100644 Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.txt
   create mode 100644 Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.example.dt.yaml: mmc@aa0000: compatible: 'oneOf' conditional failed, one must be fixed:
	['marvell,armada-3700-sdhci'] is too short
	'marvell,armada-3700-sdhci' is not one of ['marvell,armada-cp110-sdhci', 'marvell,armada-ap806-sdhci']
	'marvell,armada-ap807-sdhci' was expected
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.example.dt.yaml: mmc@ab0000: compatible: 'oneOf' conditional failed, one must be fixed:
	['marvell,armada-3700-sdhci'] is too short
	'marvell,armada-3700-sdhci' is not one of ['marvell,armada-cp110-sdhci', 'marvell,armada-ap806-sdhci']
	'marvell,armada-ap807-sdhci' was expected
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml

doc reference errors (make refcheckdocs):

Chris, your own dt binding does not pass it's check (example)...

After updating the compatibles, you need to check the example. The
examples are anyway duplicating common stuff, so half of them could be
removed.

Yeah silly me. I started taking short cuts to run dt_binding_check
dtbs_check as one command but then the dt_bindings_check output scrolled
off the top of my terminal.

As for the examples themselves I want to leave what's there as a fairly
direct translation of the old binding. If we consider them unnecessary
removing them can be done as a follow-up.

The examples cannot have warnings/errors.

I was referring to the comment of removing examples. The v5 of this 
series addressed the error in the example.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel