Re: [PATCH v1 04/12] dt-bindings: clock: imx: Add documentation for i.MXRT1170 clock
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2022-03-27 19:12:24
Also in:
linux-clk, linux-devicetree, linux-gpio, lkml
On 26/03/2022 15:43, Jesse Taube wrote:
Add DT binding documentation for i.MXRT1170 clock driver. Cc: Giulio Benetti <giulio.benetti@benettiengineering.com> Signed-off-by: Jesse Taube <redacted> --- .../bindings/clock/imxrt1170-clock.yaml | 59 +++++++++++++++++++ 1 file changed, 59 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/imxrt1170-clock.yaml
Missing vendor prefix in file name. Add "fsl,"
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/clock/imxrt1170-clock.yaml b/Documentation/devicetree/bindings/clock/imxrt1170-clock.yaml new file mode 100644 index 000000000000..ca0f9ba8b3da --- /dev/null +++ b/Documentation/devicetree/bindings/clock/imxrt1170-clock.yaml@@ -0,0 +1,59 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/clock/imxrt1170-clock.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Clock bindings for Freescale i.MXRT
Really wrong name. This is name of hardware, not "bindings". It's not for every i.MXRT, is it? Just like you did in patch #3, so this could be: Freescale i.MXRT1170 Clock Controller Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel