Re: [PATCH v6 3/4] ipmi: ssif_bmc: Return -EFAULT if copy_from_user() fails
From: Dan Carpenter <hidden>
Date: 2022-03-17 08:40:02
Also in:
linux-aspeed, linux-devicetree, linux-i2c, lkml, openbmc
On Thu, Mar 17, 2022 at 02:45:19PM +0700, Quan Nguyen wrote:
Added Dan as I have missed Dan's email address in the first place. My apologize, - Quan On 11/03/2022 13:58, Wolfram Sang wrote:quoted
On Thu, Mar 10, 2022 at 06:41:18PM +0700, Quan Nguyen wrote:quoted
From: Dan Carpenter <redacted> The copy_from_user() function returns the number of bytes remaining to be copied but we should return -EFAULT here. Fixes: 501c25b59508 ("ipmi: ssif_bmc: Add SSIF BMC driver") Signed-off-by: Dan Carpenter <redacted> Signed-off-by: Corey Minyard <redacted> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>It is nice that you want to keep this patch seperate to give Dan credits, but I still think it should be merged into patch 1, so the initial driver is as flawless as it can be. You could give Dan still credits by mentioning him in the commit message IMO. Dan, would you be fine with this?
Yes, that's no problem. Thanks! regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel