Re: [PATCH 1/3] crypto: sm4 - create SM4 library based on sm4 generic code
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
Date: 2022-03-11 23:04:32
Also in:
linux-crypto, lkml
Hi Tianjia, On Wed, Mar 2, 2022 at 3:23 PM Eric Biggers [off-list ref] wrote:
On Wed, Mar 02, 2022 at 01:26:13AM +0100, Jason A. Donenfeld wrote:quoted
On Wed, Mar 2, 2022 at 1:24 AM Herbert Xu [off-list ref] wrote:quoted
On Tue, Mar 01, 2022 at 11:34:28AM +0100, Jason A. Donenfeld wrote:quoted
quoted
lib/crypto/Kconfig | 3 + lib/crypto/Makefile | 3 + lib/crypto/sm4.c | 184 +++++++++++++++++++++++++++++++++++++++++++If this is only used by the crypto API, it does not belong in lib/crypto.Nope there is no such rule. lib/crypto is fine if you're adding code that is shared between crypto and arch/*/crypto.The sprawling madness continues then... Noted.I think it would make more sense for this code to be in crypto/, for the reason that Jason gave.
Were you planning on submitting a patch for this? Thanks, Jason _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel