On Thu, Mar 10, 2022 at 4:01 AM Joe Perches [off-list ref] wrote:

On Tue, 2022-03-08 at 18:09 +0800, Chen-Yu Tsai wrote:

quoted

The caller of mtk_pctrl_show_one_pin() is responsible for printing the
full line. mtk_pctrl_show_one_pin(), called through mtk_pctrl_dbg_show(),
should only produce a string containing the extra information the driver
wants included.

Does this function have another caller?

It looks as if this function doesn't need to be EXPORT_SYMBOL_GPL
and could just be declared static in the file instead.

Judging from the commit history, I suspect there might have been plans
for using this in another module?

I can do a patch to make it static until that ever happens.

btw: using %1d is mostly senseless as a control, but has some
     documentary use as a value < 0 or >= 10 will be always be
     fully emitted anyway.

Ack. But we could just leave it be.


Regards
ChenYu

quoted

diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c

[]

quoted

@@ -634,14 +634,10 @@ ssize_t mtk_pctrl_show_one_pin(struct mtk_pinctrl *hw,
                      pullen,
                      pullup);

-     if (r1 != -1) {
-             len += scnprintf(buf + len, buf_len - len, " (%1d %1d)\n",
-                     r1, r0);
-     } else if (rsel != -1) {
-             len += scnprintf(buf + len, buf_len - len, " (%1d)\n", rsel);
-     } else {
-             len += scnprintf(buf + len, buf_len - len, "\n");
-     }
+     if (r1 != -1)
+             len += scnprintf(buf + len, buf_len - len, " (%1d %1d)", r1, r0);
+     else if (rsel != -1)
+             len += scnprintf(buf + len, buf_len - len, " (%1d)", rsel);

      return len;
 }

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel