Thread (18 messages) 18 messages, 4 authors, 2022-03-08

RE: [PATCH v2 7/7] tty: serial: samsung: simplify getting OF match data

From: "Alim Akhtar" <alim.akhtar@samsung.com>
Date: 2022-03-07 18:16:33
Also in: linux-samsung-soc, linux-serial, lkml

-----Original Message-----
From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com]
Sent: Monday, March 7, 2022 1:39 PM
To: Krzysztof Kozlowski <redacted>; Alim Akhtar
[off-list ref]; Greg Kroah-Hartman
[off-list ref]; Jiri Slaby [off-list ref]; linux-arm-
kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
serial@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [PATCH v2 7/7] tty: serial: samsung: simplify getting OF match
data
Simplify the code with of_device_get_match_data().

Signed-off-by: Krzysztof Kozlowski <redacted>
---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

quoted hunk ↗ jump to hunk
drivers/tty/serial/samsung_tty.c | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/tty/serial/samsung_tty.c
b/drivers/tty/serial/samsung_tty.c
index 3ffae912217c..61c530bb377f 100644
--- a/drivers/tty/serial/samsung_tty.c
+++ b/drivers/tty/serial/samsung_tty.c
@@ -2150,23 +2150,16 @@ static int s3c24xx_serial_init_port(struct
s3c24xx_uart_port *ourport,

/* Device driver serial port probe */

-#ifdef CONFIG_OF
-static const struct of_device_id s3c24xx_uart_dt_match[]; -#endif
-
static int probe_index;

static inline const struct s3c24xx_serial_drv_data *
s3c24xx_get_driver_data(struct platform_device *pdev)  {  #ifdef CONFIG_OF
-	if (pdev->dev.of_node) {
-		const struct of_device_id *match;
-
-		match = of_match_node(s3c24xx_uart_dt_match, pdev-
quoted
dev.of_node);
-		return (struct s3c24xx_serial_drv_data *)match->data;
-	}
+	if (pdev->dev.of_node)
+		return of_device_get_match_data(&pdev->dev);
#endif
+
	return (struct s3c24xx_serial_drv_data *)
			platform_get_device_id(pdev)->driver_data;
}
--
2.32.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help