Re: [PATCH 2/3] media: imx: Rename imx7-mipi-csis.c to imx-mipi-csis.c
From: "Rui Miguel Silva" <rmfrfs@gmail.com>
Date: 2022-02-14 11:01:46
Also in:
linux-media, linux-staging
Hi Laurent, On Fri Feb 11, 2022 at 8:42 PM WET, Laurent Pinchart wrote:
Hi Jacopo, Thank you for the patch. On Fri, Feb 11, 2022 at 07:02:15PM +0100, Jacopo Mondi wrote:quoted
Rename the imx7-mipi-csis.c driver to remove the reference to i.MX7. The driver is for an IP core found on i.MX7 and i.MX8 SoC so do not specify a SoC version number in the driver name.I'm not against this, but I think we should then rename the symbols in the source code too. I don't mind keeping the current name if the rename causes too much churn.
I think Jacopo does that in the 3/3 patch in the source and I think he cover all, since the main symbols namespace is mipi_csis and do not include imx7 specifically. Cheers, Rui
quoted
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> --- MAINTAINERS | 2 +- .../media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename drivers/media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c} (100%)diff --git a/MAINTAINERS b/MAINTAINERS index 5bdb8c881b0b..7def3b7d56bc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS@@ -11891,7 +11891,7 @@ T: git git://linuxtv.org/media_tree.git F: Documentation/admin-guide/media/imx7.rst F: Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml F: Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml
quoted
-F: drivers/media/platform/imx/imx7-mipi-csis.c +F: drivers/media/platform/imx/imx-mipi-csis.c F: drivers/staging/media/imx/imx7-media-csi.c MEDIA DRIVERS FOR HELENEdiff --git a/drivers/media/platform/imx/imx7-mipi-csis.c b/drivers/media/platform/imx/imx-mipi-csis.c similarity index 100% rename from drivers/media/platform/imx/imx7-mipi-csis.c rename to drivers/media/platform/imx/imx-mipi-csis.c-- Regards, Laurent Pinchart
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel