Re: [PATCH] gpio: rockchip: Reset int_bothedge when changing trigger
From: Bartosz Golaszewski <hidden>
Date: 2022-02-16 14:55:47
Also in:
linux-gpio, linux-rockchip, lkml
On Sat, Feb 12, 2022 at 9:50 PM Samuel Holland [off-list ref] wrote:
With v2 hardware, an IRQ can be configured to trigger on both edges via
a bit in the int_bothedge register. Currently, the driver sets this bit
when changing the trigger type to IRQ_TYPE_EDGE_BOTH, but fails to reset
this bit if the trigger type is later changed to something else. This
causes spurious IRQs, and when using gpio-keys with wakeup-event-action
set to EV_ACT_(DE)ASSERTED, those IRQs translate into spurious wakeups.
Fixes: 3bcbd1a85b68 ("gpio/rockchip: support next version gpio controller")
Reported-by: Guillaume Savaton <redacted>
Tested-by: Guillaume Savaton <redacted>
Signed-off-by: Samuel Holland <samuel@sholland.org>
---Queued for fixes, thanks! Bart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel