Re: [PATCH v2 00/10] update Facebook Bletchley BMC
flat view
From: Joel Stanley <joel@jms.id.au>
Date: 2022-02-15 05:51:47
Also in:
linux-aspeed, linux-devicetree, lkml
On Mon, 14 Feb 2022 at 04:26, Potin Lai [off-list ref] wrote:
This patch series update Facebook Bletchley BMC devicetree base on EVT HW schematioc design, and rebase SLED numbering to 1-based for OpenBMC multi-host. - GPIO: - adding more gpio line names - include interrupt line in io expander for gpio interrupt monitoring - SPI flash: - adding dual flash BSM module support - switch to spi2-gpio on spi2 due to unstable signal issue - Hwmon Sensors: - adding INA230 sensors for monitoring - fix ADM1278 shunt-resistor - MDIO Bus: enable mido3 bus - RTC: switch to external battery-backed rtc - OpenBMC: 1-based SLED numbering LINK: [v1] https://lore.kernel.org/all/20220211014347.24841-1-potin.lai@quantatw.com/ (local) Changes v1 --> v2: - update the details of new added gpio line names in commit message - add battery-backed rtc information in comment and commit message
Looks good. I made some comments on the spi2 patch, please fix those up and I will merge. Note that the convention for patch names is: ARM: dts: aspeed: bletchley: Description with sentence case If you could update your patches to follow that it would be appreciated. There's no need to re-send your series for the openbmc tree; I can merge those once we've reviewed the ones for mainline. Cheers, Joel
Potin Lai (10): arch: arm: dts: bletchley: switch sled numbering to 1-based arch: arm: dts: bletchley: separate leds into multiple groups arch: arm: dts: bletchley: update gpio-line-names arch: arm: dts: bletchley: update fmc configurations arch: arm: dts: bletchley: switch to spi-gpio for spi2 arch: arm: dts: bletchley: add interrupt support for sled io expander arch: arm: dts: bletchley: add shunt-resistor for ADM1278 arch: arm: dts: bletchley: add INA230 sensor on each sled arch: arm: dts: bletchley: enable mdio3 bus arch: arm: dts: bletchley: cleanup redundant nodes .../dts/aspeed-bmc-facebook-bletchley.dts | 303 +++++++++++------- 1 file changed, 194 insertions(+), 109 deletions(-) -- 2.17.1
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel