Re: [PATCH v3 3/3] pinctrl: canonical rsel resistance selection property
From: Guodong Liu <hidden>
Date: 2022-02-14 03:03:41
Also in:
linux-devicetree, linux-gpio, linux-mediatek, lkml
-----Original Message----- From: AngeloGioacchino Del Regno < angelogioacchino.delregno@collabora.com> To: Guodong Liu <redacted>, Linus Walleij < linus.walleij@linaro.org>, Rob Herring [off-list ref], Matthias Brugger [off-list ref], Sean Wang [off-list ref] Cc: Sean Wang <sean.wang@mediatek.com>, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v3 3/3] pinctrl: canonical rsel resistance selection property Date: Thu, 10 Feb 2022 09:50:45 +0100 Il 10/02/22 07:21, Guodong Liu ha scritto:
Change "mediatek,rsel_resistance_in_si_unit" to "mediatek,rsel- resistance-in-si-unit" Signed-off-by: Guodong Liu <redacted>
Hello Guodong,
thanks for the patch!
However, you forgot to add the required Fixes tag to this one; this
patch
should be fixing fb34a9ae383a ("pinctrl: mediatek: support rsel
feature").
Please add the required tag.
Thanks,
Angelo
Hi Angelo
We will update it for next version.
Thanks
Guodongquoted hunk ↗ jump to hunk
--- drivers/pinctrl/mediatek/pinctrl-paris.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.cb/drivers/pinctrl/mediatek/pinctrl-paris.c index d4e02c5d74a8..38c0f0c4cf95 100644--- a/drivers/pinctrl/mediatek/pinctrl-paris.c +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c@@ -989,7 +989,7 @@ int mtk_paris_pinctrl_probe(structplatform_device *pdev, hw->nbase = hw->soc->nbase_names; if (of_find_property(hw->dev->of_node, - "mediatek,rsel_resistance_in_si_unit", NULL)) + "mediatek,rsel-resistance-in-si-unit", NULL)) hw->rsel_si_unit = true; else hw->rsel_si_unit = false;
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel