Thread (19 messages) 19 messages, 3 authors, 2022-02-14

RE: [PATCH v6 7/8] PCI: imx6: Disable enabled clocks and regulators after link is down

From: Hongxing Zhu <hongxing.zhu@nxp.com>
Date: 2022-02-09 04:13:05
Also in: linux-pci, lkml

-----Original Message-----
From: Fabio Estevam <festevam@gmail.com>
Sent: 2022年2月9日 10:02
To: Hongxing Zhu <hongxing.zhu@nxp.com>
Cc: Lucas Stach <l.stach@pengutronix.de>; Bjorn Helgaas
[off-list ref]; Mark Brown [off-list ref]; Lorenzo Pieralisi
[off-list ref]; Jingoo Han [off-list ref];
linux-pci@vger.kernel.org; dl-linux-imx [off-list ref]; moderated
list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
[off-list ref]; linux-kernel
[off-list ref]; Sascha Hauer [off-list ref]
Subject: Re: [PATCH v6 7/8] PCI: imx6: Disable enabled clocks and regulators
after link is down

Hi Richard,

On Tue, Feb 8, 2022 at 10:56 PM Hongxing Zhu [off-list ref]
wrote:
quoted
Do you mean that we should ignore the return of dw_pcie_host_init()
and finish the _probe without an error return?
Yes, we should not return an error on probe if the link is down.

Thanks
Hi Fabio:
Regarding my understand, the suspend/resume callbacks would be hooked if the
 probe is complete successfully. There would be extra more than 100ms delay
 in every system resume operations.
I'm afraid that it would bring bad experience for the power management.

Is there a policy that we should obey, and let the probe complete without
an error return?
If yes, I can follow your suggestion, wouldn't return an error on probe when
link is down.

Thanks.
Best Regards
Richard Zhu
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help