Thread (4 messages) flat view 4 messages, 2 authors, 2022-02-10

Re: [PATCH] i2c: bcm2835: Fix the error handling in 'bcm2835_i2c_probe()'

From: Wolfram Sang <wsa@kernel.org>
Date: 2022-02-07 15:12:13
Also in: kernel-janitors, linux-i2c, lkml

On Fri, Aug 20, 2021 at 08:43:33PM +0200, Christophe JAILLET wrote:
Some resource should be released if an error occurs in
'bcm2835_i2c_probe()'.
Add an error handling path and the needed 'clk_disable_unprepare()' and
'clk_rate_exclusive_put()' calls.

While at it, rework the bottom of the function to use this newly added
error handling path and have an explicit and more standard "return 0;" at
the end of the normal path.

Fixes: bebff81fb8b9 ("i2c: bcm2835: Model Divider in CCF")
Signed-off-by: Christophe JAILLET <redacted>
Sadly, noone tested it but I think it is good to avoid the resource
leaks. So, rebased and applied to for-next, thanks! Please kindly check
if I rebased correctly the irq error case (once I pushed out).
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help