Re: [RFC PATCH v3 05/11] ARM: dts: bcm2711: Add unicam CSI nodes
From: Stefan Wahren <hidden>
Date: 2022-02-02 18:24:30
Also in:
linux-devicetree, linux-media, lkml
Hi Jean-Michel, Am 02.02.22 um 18:56 schrieb Jean-Michel Hautbois:
Add both MIPI CSI-2 nodes in the core bcm2711 tree. Use the 3-cells interrupt declaration, corresponding clocks and default as disabled. Signed-off-by: Jean-Michel Hautbois <redacted>
this patch needs an Ack from the BCM2835 maintainer(s), so please include them. scripts/get_maintainers.pl is your friend.
quoted hunk ↗ jump to hunk
--- arch/arm/boot/dts/bcm2711.dtsi | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+)diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi index dff18fc9a906..9ad50d4c0c16 100644 --- a/arch/arm/boot/dts/bcm2711.dtsi +++ b/arch/arm/boot/dts/bcm2711.dtsi@@ -3,6 +3,7 @@ #include <dt-bindings/interrupt-controller/arm-gic.h> #include <dt-bindings/soc/bcm2835-pm.h> +#include <dt-bindings/power/raspberrypi-power.h>
The file bcm2711.dtsi is reserved for the BCM2711 SoC and shouldn't used for board specific stuff. So please ...
quoted hunk ↗ jump to hunk
/ { compatible = "brcm,bcm2711";@@ -293,6 +294,30 @@ hvs: hvs@7e400000 { interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>; }; + csi0: csi@7e800000 { + compatible = "brcm,bcm2835-unicam"; + reg = <0x7e800000 0x800>, + <0x7e802000 0x4>; + interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clocks BCM2835_CLOCK_CAM0>, + <&firmware_clocks 4>; + clock-names = "lp", "vpu"; + power-domains = <&power RPI_POWER_DOMAIN_UNICAM0>;
move clocks property & power-domains property from this node and
+ status = "disabled";
+ };
+
+ csi1: csi@7e801000 {
+ compatible = "brcm,bcm2835-unicam";
+ reg = <0x7e801000 0x800>,
+ <0x7e802004 0x4>;
+ interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clocks BCM2835_CLOCK_CAM1>,
+ <&firmware_clocks 4>;
+ clock-names = "lp", "vpu";
+ power-domains = <&power RPI_POWER_DOMAIN_UNICAM1>;from this node to bcm2711-rpi.dtsi. Best regards
+ status = "disabled";
+ };
+
pixelvalve3: pixelvalve@7ec12000 {
compatible = "brcm,bcm2711-pixelvalve3";
reg = <0x7ec12000 0x100>;_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel