RE: [PATCH] pinctrl: fix a discarded-qualifiers build error
From: David Laight <hidden>
Date: 2022-01-25 22:17:44
Also in:
linux-gpio, linux-mediatek, lkml
From: Miles Chen
quoted hunk ↗ jump to hunk
Sent: 25 January 2022 17:55 Fix COMPILER=gcc ARCH=arm64 DEFCONFIG=allyesconfig build: log: drivers/pinctrl/pinctrl-thunderbay.c:815:29: error: assignment discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers] Fixes: 12422af8194d ("pinctrl: Add Intel Thunder Bay pinctrl driver") Signed-off-by: Miles Chen <redacted> --- drivers/pinctrl/pinctrl-thunderbay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/pinctrl/pinctrl-thunderbay.c b/drivers/pinctrl/pinctrl-thunderbay.c index b5b47f4dd774..4e6d718c03fc 100644 --- a/drivers/pinctrl/pinctrl-thunderbay.c +++ b/drivers/pinctrl/pinctrl-thunderbay.c@@ -812,7 +812,7 @@ static int thunderbay_add_functions(struct thunderbay_pinctrl *tpc, struct funct } } - grp = func->group_names; + grp = (const char **)func->group_names;
You should change the type of 'grp' not add a cast. The compiler can warn about casts removing 'const' as well. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel