Thread (84 messages) 84 messages, 6 authors, 2022-01-12

Re: [PATCH v4 02/48] perf stat: Add aggr creators that are passed a cpu.

From: John Garry <hidden>
Date: 2022-01-10 17:10:28
Also in: linux-perf-users, lkml

On 05/01/2022 06:13, Ian Rogers wrote:
  
+struct aggr_cpu_id cpu_map__get_socket(struct perf_cpu_map *map, int idx,
+				       void *data)
+{
+	if (idx < 0 || idx > map->nr)
+		return cpu_map__empty_aggr_cpu_id();
+
+	return cpu_map__get_socket_aggr_by_cpu(map->map[idx], data);
+}
+

This is later deleted in the series. Can the series be reworked so that 
we don't add stuff and then later delete it? One reason for that 
approach is that we don't spend time reviewing something which will be 
deleted, especially in such a big series...

If it really makes sense to do it this way then fine.

Thanks,
John

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help