Re: [PATCH] mailbox: add control_by_sw for mt8195

Hi Chun-Kuang,

Thanks for the reviews.

On Fri, 2021-12-10 at 23:44 +0800, Chun-Kuang Hu wrote:

Hi, Jason:

jason-jh.lin [off-list ref] 於 2021年12月10日 週五 下午2:11寫道：

quoted

To make sure the GCE request signal to SPM is not trigger by
other HW modules and cause suspend premature wake.

Set 0x7 (the bit 0~2 as 1) to GCE_GCTL_VALUE, to configure the
request signal control by SW and release the request to SPM.

How does mt8173, mt8183, and mt6779 prevent this? Or these SoCs could
not prevent this?

Regards,
Chun-Kuang.

Designer is not sure about the previous SoCs, such as mt6779, mt8173
and mt8183 whose gce is in mmsys, have the same issue or not?

So we just add this configuration for mt8195 whose gce is in infra.

Regards,
Jason-JH.Lin.

quoted

Signed-off-by: jason-jh.lin <redacted>
---
 drivers/mailbox/mtk-cmdq-mailbox.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c

b/drivers/mailbox/mtk-cmdq-mailbox.c
index a8845b162dbf..342b91f16e65 100644

--- a/drivers/mailbox/mtk-cmdq-mailbox.c
+++ b/drivers/mailbox/mtk-cmdq-mailbox.c

@@ -664,7 +664,7 @@ static const struct gce_plat gce_plat_v5 = {
 static const struct gce_plat gce_plat_v6 = {
        .thread_nr = 24,
        .shift = 3,
-       .control_by_sw = false,
+       .control_by_sw = true,
        .gce_num = 2
 };

--

2.18.0

-- 
Jason-JH Lin [off-list ref]


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel