Re: [PATCH 01/10] usb: gadget: udc: bcm63xx: fix deferred probing
From: Sergey Shtylyov <hidden>
Date: 2021-12-10 19:55:25
Also in:
linux-usb
From: Sergey Shtylyov <hidden>
Date: 2021-12-10 19:55:25
Also in:
linux-usb
On 10/27/21 12:33 AM, Florian Fainelli wrote:
quoted
The driver overrides the error codes returned by platform_get_irq() to -ENXIO for some strange reason, so if it returns -EPROBE_DEFER, the driver will fail the probe permanently instead of the deferred probing. Switch to propagating the error codes upstream. Fixes: 613065e53cb1 ("usb: gadget: bcm63xx UDC driver") Signed-off-by: Sergey Shtylyov <redacted>Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Not that this is going to happen for this particular driver on the platform where it is use MIPS BCM63XX
Thanks for noting that. I think I should re-qualify this patch from a bug fix to cleanup. I'll split the series into 2 parts now.
but this is still the right thing to do anyway.
Yes, propagating the error is the Right Thing. :-) MBR, Sergey _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel