Re: [PATCH V3] pinctrl: bcm: ns: use generic groups & functions helpers
From: Linus Walleij <hidden>
Date: 2021-12-26 03:22:55
Also in:
linux-gpio
On Wed, Dec 22, 2021 at 7:43 AM Rafał Miłecki [off-list ref] wrote:
From: Rafał Miłecki <rafal@milecki.pl>
This simplifies ns driver and gets rid of ~70 lines of code.
"const" had to be dropped from "struct ns_pinctrl_group" @pins to match
"struct group_desc" @pins and pinctrl_generic_add_group(). Otherwise it
would cause:
drivers/pinctrl/bcm/pinctrl-ns.c: In function 'ns_pinctrl_probe':
drivers/pinctrl/bcm/pinctrl-ns.c:277:13: warning: passing argument 3 of 'pinctrl_generic_add_group' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
277 | group->pins, group->num_pins, NULL);
| ~~~~~^~~~~~
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>This v3 version applied, nice work! Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel