Thread (4 messages) 4 messages, 4 authors, 2021-12-26

Re: [PATCH] pinctrl: imx: fix allocation result check

From: Abel Vesa <hidden>
Date: 2021-12-23 07:56:41
Also in: linux-gpio

On 21-12-22 22:28:07, Rafał Miłecki wrote:
From: Rafał Miłecki <rafal@milecki.pl>

Fix code to check correct variable value.

Reported-by: Abel Vesa <redacted>
Reviewed-by: Abel Vesa <redacted>
quoted hunk ↗ jump to hunk
Fixes: 02f117134952 ("pinctrl: imx: prepare for making "group_names" in "function_desc" const")
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
Linus: I'm not sure if you can rebase your tree. Treat it as separated
patch or fixup. Depending on how to manage your repository.
---
 drivers/pinctrl/freescale/pinctrl-imx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
index 47b2ab1a14d0..16bc1bfc03e4 100644
--- a/drivers/pinctrl/freescale/pinctrl-imx.c
+++ b/drivers/pinctrl/freescale/pinctrl-imx.c
@@ -667,7 +667,7 @@ static int imx_pinctrl_parse_functions(struct device_node *np,
 
 	group_names = devm_kcalloc(ipctl->dev, func->num_group_names,
 				   sizeof(char *), GFP_KERNEL);
-	if (!func->group_names)
+	if (!group_names)
 		return -ENOMEM;
 	for_each_child_of_node(np, child)
 		group_names[i] = child->name;
-- 
2.31.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help