Re: [PATCH] ARM: dts: BCM5301X: Add USB GPIO and missing LEDs on Netgear R6300v2

On 10.12.2021 10:18, Lisa Hill wrote:

On Dec 10, 2021, at 15:39, Rafał Miłecki [off-list ref] wrote:

quoted

One more comment on sending patches: please configure your e-mail client
to send text only (text/plain) without extra HTML version (text/html).

If you can't configure your e-mail easily you can also try
"git send-email" command line tool.

See:
https://www.kernel.org/doc/html/v5.15/process/submitting-patches.html#no-mime-no-links-no-compression-no-attachments-just-plain-text
https://www.kernel.org/doc/html/v5.15/process/email-clients.html

Also see comments below.

Thanks for your help. I have noticed the #no-mime-no-links-no-compression-no-attachments-just-plain-text warning from The Linux Kernel documentation. However I sent a Safari-copied html mail by accident which was rejected by linux-arm-kernel@lists.infradead.org. Now I have configured my e-mail client to send plain text by default. Can you verify that on my reply?

It's perfect.

Should I cc to Florian Fainelli [off-list ref] and Hauke Mehrtens [off-list ref] any more?  I have noticed your two e-mail clients from commits: rafal@milecki.pl and zajec5@gmail.com. Which one should I use to contact you? Should I cc to another?

Yes, please include Florian & Hauke.
Either of my addresses is fine.

quoted

quoted

+		};
+		

No tabs in empty separator line please.

I forgot to remove tabs when I made this commit on Github. Sorry for that.

The linux repo is too big for me to clone. I have to use the fork feature in Github if I want to use git diff to create the patch. That’s why I can’t use "git send-email” which is recommended by The Linux Kernel documentation. Do you have any idea how I can send you the patch directly from Github instead of a 3rd e-mail client?

You can limit amount of cloned data by using --depth. Maybe that will
help.

git clone -–depth 10 git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

I'm not familiar with GitHub, I don't know if it supports sending
patches.

Since I can’t reply to your comment and provide a clean modified patch at the same time, I will send you a modified patch later.

quoted

quoted

+		wan-amber {
+			label = "bcm53xx:amber:wan";
+			gpios = <&chipcommon 10 GPIO_ACTIVE_HIGH>;
  		};

It's unlikely both WAN LEDs (green & amber) are controlled by the same
GPIO (10). Please verify that.

I did verify that following the "Adding new device support” guide from OpenWrt. It bothered me too since I have never noticed this thing on any other device. I think you can verify that on your Netgear R6250 since they are very similar. I will remove the wan-amber LED later to respond to your concern.

Well, please just double check what *really* happens when you set GPIO
10 to 0/1 value. Which LED does really turn on/off? Please don't just
randomly add/remove info from DT. Please verify it instead and provide
accurate changes.

However, I haven't verified the vcc-gpio configuration for USB port and I just ported this feature from the dts file of Netgear R6250.

Then please kindly verify that. Please check if USB devices get detected
without this change. Please don't send random / untested changes.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel