Thread (12 messages) 12 messages, 4 authors, 2021-12-03

Re: [PATCH v2 0/4] Avoid live-lock in fault-in+uaccess loops with sub-page faults

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2021-12-03 18:25:39
Also in: linux-btrfs, linux-fsdevel, lkml

On Fri, Dec 3, 2021 at 10:12 AM Andreas Gruenbacher [off-list ref] wrote:
It happens when you mmap a file and write the mmapped region to
another file, for example.
Do you actually have such loads? Nobody should use mmap() for
single-access file copy purposes. It's slower than just doing the copy
exactly due to page fault overhead.

In other words, you seem to be worrying about the performance of a
load that is _explicitly_ badly written. You should be fixing the
application, not making the kernel do stupid things.

Also, it's worth noting that that situation should be caught by the
page-in code, which will map multiple pages in one go
(do_fault_around() - for when the pages are cached), and do the
readahead logic (filemap_fault() - for when the pages aren't in the
page cache).

Both of which are a lot more important than the "synchronously fault
in pages one at a time".

                Linus

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help