A Andrew Morton #
Message details and related content
On Tue, 28 Dec 2021 13:34:21 +0800 Calvin Liao [off-list ref] wrote:
From: "calvin.liao" <redacted> Add to release seccomp after killing terminate clone/fork to avoid memory leak when enabling CONFIG_SECCOMP.
Help us out here - where was this filter allocated? Please describe
the code flow which led to this leak. Rather than simply saying "there
is a leak".
quoted hunk
--- a/kernel/fork.c +++ b/kernel/fork.c@@ -1698,6 +1698,13 @@ static void copy_seccomp(struct task_struct *p) #endif } +static void release_seccomp(struct task_struct *p) +{ +#ifdef CONFIG_SECCOMP + seccomp_filter_release(p); +#endif
ifdefs aren't needed?
quoted hunk
+} + SYSCALL_DEFINE1(set_tid_address, int __user *, tidptr) { current->clear_child_tid = tidptr;@@ -2405,6 +2412,7 @@ static __latent_entropy struct task_struct *copy_process( return p; bad_fork_cancel_cgroup: + release_seccomp(p);
Why not simply call seccomp_filter_release() here, without ifdefs?
sched_core_free(p); spin_unlock(¤t->sighand->siglock); write_unlock_irq(&tasklist_lock);
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel