Re: [PATCH v3] soc: ti: smartreflex: Use platform_get_irq_optional() to get the interrupt

Hi Andy,

Thank you for the review.

On Sat, Dec 25, 2021 at 4:56 PM Andy Shevchenko
[off-list ref] wrote:

On Sat, Dec 25, 2021 at 4:08 AM Lad Prabhakar
[off-list ref] wrote:

quoted

platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
allocation of IRQ resources in DT core code, this causes an issue
when using hierarchical interrupt domains using "interrupts" property
in the node as this bypasses the hierarchical setup and messes up the
irq chaining.

In preparation for removal of static setup of IRQ resource from DT core
code use platform_get_irq_optional().

...

quoted

+       ret = platform_get_irq_optional(pdev, 0);
+       if (ret < 0 && ret != -ENXIO) {

quoted

+               dev_err(&pdev->dev, "%s: failed to get IRQ resource\n", __func__);
+               return ret;

Almost fine, but you should exclude this from the deferred probe, so switch to

  return dev_err_probe(...);

Agreed.

quoted

+       }
+       if (ret > 0)
+               sr_info->irq = ret;

...

quoted

+       ret = 0;

I do not see the context, is it really necessary?

Yes the change is necessary as the probe callback returns ret on
success, and in the below code flow there might be a case where ret
inst set. So setting the ret here.

Cheers,
Prabhakar

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel