Re: [PATCH 2/2] iommu/arm-smmu: Propagate errors from platform_get_irq()
From: Robin Murphy <robin.murphy@arm.com>
Date: 2021-12-23 14:19:34
Also in:
linux-iommu, lkml
On 2021-12-23 13:00, Lad Prabhakar wrote:
The driver overrides the error code returned by platform_get_irq() to -ENODEV. Switch to propagating the error code upstream so that errors such as -EPROBE_DEFER are handled.
I wouldn't usually expect an SMMU to be wired up to a secondary interrupt controller that could cause deferral, but on the other hand I don't think there's any good reason *not* to propagate the original error anyway, so sure, why not. Reviewed-by: Robin Murphy <robin.murphy@arm.com>
quoted hunk ↗ jump to hunk
Fixes: 9ec36cafe43b ("of/irq: do irq resolution in platform_get_irq") Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> --- drivers/iommu/arm/arm-smmu/arm-smmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.c b/drivers/iommu/arm/arm-smmu/arm-smmu.c index 4844cd075644..6cf5612efcda 100644 --- a/drivers/iommu/arm/arm-smmu/arm-smmu.c +++ b/drivers/iommu/arm/arm-smmu/arm-smmu.c@@ -2129,7 +2129,7 @@ static int arm_smmu_device_probe(struct platform_device *pdev) int irq = platform_get_irq(pdev, i); if (irq < 0) - return -ENODEV; + return irq; smmu->irqs[i] = irq; }
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel